Hi, Amit Langote wrote:
> 2. If I understand the description you provided in [1] correctly, the > point of having ri_PartitionIsValid and ExecInitExtraPartitionInfo() is to > avoid possibly-redundantly performing following two steps in > ExecSetupPartitionTupleRouting() for *reused* partition ResultRelInfos > that may not be used for tuple routing after all: > > - create the parent_child_tupconv_maps[] entry for it > - perform FDW tuple routing initialization. > > If that's true, the following comment could be expanded just a little bit > to make that clearer: > > /* > * ExecInitPartitionExtraInfo > * Do the remaining initialization work for the given partition Yeah, I think the comments on why this is a separate step should be more extensive. Probably add something to ExecInitPartitionInfo too. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
