On 8 March 2018 at 17:23, Edmund Horner <ejr...@gmail.com> wrote: > New patch that fixes a little bug with appending NULL addons to schema > queries.
Hi all, I haven't heard anything for a while and so assume you're beavering away on real features. :) I've been dogfooding this patch at work, and I am personally pretty happy with it. I still think the number of completions on an empty string is a bit too big, but I don't know what to omit. There are around 1700 completions on the empty "postgres" database in my testing, and we show the first 1000 (arbitrarily limited, as the generated SQL has LIMIT 1000 but no ORDER BY). Should we just leave it as is? Whether we improve the filtering or not, I'm optimistic the feature will be committed in this CF or the next. I've also been working on adding support for completions after commas, but I really want to see the current feature finished first. Cheers, Edmund
