John Naylor <jcnay...@gmail.com> writes:
> On 3/22/18, Tom Lane <t...@sss.pgh.pa.us> wrote:
>> While I'm thinking of it --- I noticed one or two places where you
>> had "BKI_DEFAULT(\0)".
> Hmm, I only see this octal in pg_type.h
> char typdelim BKI_DEFAULT(\054);
Sorry, I was going by memory rather than looking at the code.
> Which I hope is fine.
I don't really think it's legal C; I'd rather write BKI_DEFAULT('\054').
> Were you thinking of this comment in
> pg_attribute.h? We use the double-quoted empty string for postgres.bki
> and change it to '\0' for schemapg.h.
> /* One of the ATTRIBUTE_IDENTITY_* constants below, or '\0' */
> char attidentity BKI_DEFAULT("");
That definitely seems like a hack --- why not BKI_DEFAULT('\0') ?
regards, tom lane
