> On Wed, 28 Mar 2018 15:45:09 +0900 (JST) > Tatsuo Ishii <is...@sraoss.co.jp> wrote: > >> >> I found the previous patch was broken and this can't handle >> >> views that has subqueries as bellow; >> >> >> >>  CREATE VIEW lock_view6 AS SELECT * from (select * from lock_tbl1) sub; >> >> >> >> I fixed this and attached the updated version including additional tests. >> > >> > This patch gives a warning while compiling: >> > >> > lockcmds.c:186:1: warning: no semicolon at end of struct or union >> > } LockViewRecurse_context; >> > ^ >> >> Also I get a regression test failure: > > Thank you for your reviewing my patch. > I attached the updated patch, v10.
Thanks. Looks good to me. I marked the patch as "Ready for Committer". Unless there's an objection, especially from Robert or Thomas Munro, I am going to commit/push it. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp