On 2021-Oct-26, Aleksander Alekseev wrote: > > In short: I'm not okay with doing > > s/MakeTupleTableSlot/MakeSingleTupleTableSlot/g in a patch that doesn't > > also introduce matching ExecDropSingleTupleTableSlot calls (unless those > > exist somewhere already; but where?). If we did clean that up, maybe > > MakeTupleTableSlot could become "static". But I'd still be inclined to > > keep it physically separate, leaving it to the compiler to decide whether > > to inline it into the callers.
Another point that could be made is that perhaps MakeSingleTupleTableSlot should always construct a slot using virtual tuples rather than passing TTSOps as a parameter? -- Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/ "Ellos andaban todos desnudos como su madre los parió, y también las mujeres, aunque no vi más que una, harto moza, y todos los que yo vi eran todos mancebos, que ninguno vi de edad de más de XXX años" (Cristóbal Colón)
