"Bossart, Nathan" <bossa...@amazon.com> writes: > On 10/31/21, 1:55 PM, "Tom Lane" <t...@sss.pgh.pa.us> wrote: >> 1. Attached is a proposed patch to get rid of the calls in trgm_regexp.c.
> Should there be a list_free(trgmNFA->queue) at the end of > transformGraph()? There could be, but that's visibly invoked only once per createTrgmNFAInternal call, so I didn't think it was worthwhile to do so (unlike the case for processState). If we were concerned about leakage in that function, the hash table would be a far bigger issue. regards, tom lane