On Friday, October 29, 2021 1:24 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > I've attached a new version patch. Since the syntax of skipping > transaction id is under the discussion I've attached only the error > reporting patch for now. > >
Thanks for your patch. Some comments on 026_error_report.pl file. 1. For test_tab_streaming table, the test only checks initial table sync and doesn't check anything related to the new view pg_stat_subscription_workers. Do you want to add more test cases for it? 2. The subscriptions are created with two_phase option on, but I didn't see two phase transactions. Should we add some test cases for two phase transactions? 3. Errors reported by table sync worker will be cleaned up if the table sync worker finish, should we add this case to the test? (After checking the table sync worker's error in the view, delete data which caused the error, then check the view again after table sync worker finished.) Regards Tang
