Hi, On 2021-11-04 19:17:05 +0100, Peter Eisentraut wrote: > On 01.11.21 00:24, Andres Freund wrote: > > - remaining hardcoded configure tests (e.g. ACCEPT_TYPE_ARG*) > > I think we can get rid of that one.
Oh, nice! I was somewhat confused by "unsigned int PASCAL" as a type. > That test originally catered to some strange edge cases where the third > argument was size_t that was not the same size as int. That is long gone, > if it ever really existed. All systems currently of interest use either > socklen_t or int, and socklen_t is always int. (A few build farm animals > report size_t, but they are all 32-bit.) > diff --git a/src/include/c.h b/src/include/c.h > index c8ede08273..7c790f557e 100644 > --- a/src/include/c.h > +++ b/src/include/c.h > @@ -408,6 +408,10 @@ typedef unsigned char bool; > * ---------------------------------------------------------------- > */ > > +#ifndef HAVE_SOCKLEN_T > +typedef socklen_t int; > +#endif I'd put this in port.h instead of c.h, or is there a reason not to do so? Probably worth putting this in fairly soon independent of whether anything happens wrt meson? Greetings, Andres Freund
