On Tue, Nov 9, 2021 at 2:02 PM Joshua Brindle <joshua.brin...@crunchydata.com> wrote: > > On Tue, Nov 9, 2021 at 1:59 PM Joshua Brindle > <joshua.brin...@crunchydata.com> wrote: > > > > On Fri, Nov 5, 2021 at 6:01 AM Daniel Gustafsson <dan...@yesql.se> wrote: > > > > > > Attached is a rebase fixing a tiny bug in the documentation which > > > prevented it > > > from being able to compile. > > > > > > > Hello, I'm looking to help out with reviews for this CF and I'm > > currently looking at this patchset. > > > > currently I'm stuck trying to configure: > > > > checking for nss-config... /usr/bin/nss-config > > checking for nspr-config... /usr/bin/nspr-config > > ... > > checking nss/ssl.h usability... no > > checking nss/ssl.h presence... no > > checking for nss/ssl.h... no > > configure: error: header file <nss/ssl.h> is required for NSS > > > > This is on fedora 33 and nss-devel is installed, nss-config is > > available (and configure finds it) but the directory is different from > > Ubuntu: > > (base) [vagrant@fedora ~]$ nss-config --includedir > > /usr/include/nss3 > > (base) [vagrant@fedora ~]$ ls -al /usr/include/nss3/ssl.h > > -rw-r--r--. 1 root root 70450 Sep 30 05:41 /usr/include/nss3/ssl.h > > > > So if nss-config --includedir is used then #include <ssl.h> should be > > used, or if not then #include <nss3/ssl.h> but on this system #include > > <nss/ssl.h> is not going to work. > > FYI, if I make a symlink to get past this, configure completes but > compilation fails because nspr/nspr.h cannot be found (I'm not sure > why configure doesn't discover this) > ../../src/include/common/nss.h:31:10: fatal error: 'nspr/nspr.h' file not > found > #include <nspr/nspr.h>In file included from protocol_nss.c:24: > ../../src/include/common/nss.h:31:10: fatal error: 'nspr/nspr.h' file not > found > #include <nspr/nspr.h> > ^~~~~~~~~~~~~ > > It's a similar issue: > $ nspr-config --includedir > /usr/include/nspr4
If these get resolved the next issue is llvm bitcode doesn't compile because the nss includedir is missing from CPPFLAGS: /usr/bin/clang -Wno-ignored-attributes -fno-strict-aliasing -fwrapv -O2 -I../../../src/include -D_GNU_SOURCE -I/usr/include/libxml2 -I/usr/include -flto=thin -emit-llvm -c -o be-secure-nss.bc be-secure-nss.c In file included from be-secure-nss.c:20: In file included from ../../../src/include/common/nss.h:38: In file included from /usr/include/nss/nss.h:34: /usr/include/nss/seccomon.h:17:10: fatal error: 'prtypes.h' file not found #include "prtypes.h" ^~~~~~~~~~~ 1 error generated.