On 11/14/21, 4:18 AM, "Bharath Rupireddy"
<bharath.rupireddyforpostg...@gmail.com> wrote:
> Thanks. Attaching the v2 to avoid that by directly using the message
> in ereport instead of activitymsg.
+ ereport(DEBUG1,
+ (errmsg_internal("waiting for %s", xlogfname)));
As a general comment, I think we should include more detail than what
goes in the ps title. While we probably want to keep the ps title,
brief, I don't see any issue with including a bit more context in
debug statements.
+ ereport(DEBUG1,
+ (errmsg_internal("executing archive command \"%s\" for archving
%s",
+ xlogarchcmd, xlog)));
I wonder if it's necessary to include the "for archiving" part in this
one. Typically, the xlogarchcmd will include it somewhere.
Nathan
