On Friday, November 12, 2021 12:28 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Thu, Nov 11, 2021 at 12:22 PM houzj.f...@fujitsu.com > <houzj.f...@fujitsu.com> wrote: > > > > On Friday, November 5, 2021 11:20 AM Greg Nancarrow > <gregn4...@gmail.com> wrote: > > >On Thu, Nov 4, 2021 at 7:10 PM Amit Kapila > <mailto:amit.kapil...@gmail.com> wrote: > > > > > >Almost. > > >The patch does seem to solve that first problem (double publish on > tablesync). > > >I used the following test (taken from [2]), and variations of it: > > > > > >However, there did still seem to be a problem, if > > >publish_via_partition_root is then set to false; it seems that can result > > >in > duplicate partition entries in the pg_publication_tables view, see below (this > follows on from the test scenario given above): > > > > > >postgres=# select * from pg_publication_tables; pubname | schemaname > > >| tablename > > >---------+------------+----------- > > > pub1 | sch1 | tbl1 > > > pub1 | sch3 | t1 > > >(2 rows) > > > > > >postgres=# alter publication pub1 set > > >(publish_via_partition_root=false); > > >ALTER PUBLICATION > > >postgres=# select * from pg_publication_tables; pubname | schemaname > > >| tablename > > >---------+------------+------------ > > > pub1 | sch2 | tbl1_part1 > > > pub1 | sch2 | tbl1_part2 > > > pub1 | sch2 | tbl1_part1 > > > pub1 | sch3 | t1 > > >(4 rows) > > > > > >So I think the patch would need to be updated to prevent that. > > > > Thanks for testing the patch. > > > > The reason of the duplicate output is that: > > The existing function GetPublicationRelations doesn't de-duplicate the > > output oid list. So, when adding both child and parent table to the > > publication(pubviaroot = false), the pg_publication_tables view will > > output duplicate partition. > > > > Attach the fix patch. > > 0001 fix data double publish(first issue in this thread) > > 0002 fix duplicate partition in view pg_publication_tables(reported by > > greg when testing the 0001 patch) > > > > Can we start a separate thread to discuss the 0002 patch as that doesn't seem > directly to duplicate data issues being discussed here? > Please specify the exact test in the email as that would make it easier to > understand the problem.
Thanks for the suggestion. I have started a new thread about this issue[1]. [1] https://www.postgresql.org/message-id/OS0PR01MB5716E97F00732B52DC2BBC2594989%40OS0PR01MB5716.jpnprd01.prod.outlook.com Best regards, Hou zj
