On Thu, Nov 18, 2021 at 7:53 AM Fujii Masao <masao.fu...@oss.nttdata.com> wrote: > > 1) Can't we determine the wait event type based on commandName in > > ExecuteRecoveryCommand instead of passing it as an extra param? > > Yes, that's possible. But isn't it uglier to make ExecuteRecoveryCommand() > have > the map of command name and wait event? So I feel inclined to avoid adding > something like the following code into the function... Thought? > > if (strcmp(commandName, "recovery_end_command") == 0) > wait_event_info = WAIT_EVENT_RECOVERY_END_COMMAND; > else if (strcmp(commandName, "archive_command_command") == 0)
Yeah let's not do that. I'm fine with the wait_event_for_archive_command_v2.patch as is. Regards, Bharath Rupireddy.
