On 2018-03-29 23:52:18 +0200, Tomas Vondra wrote: > > I have added details about this in src/backend/storage/lmgr/README as > > suggested by you. > > > > Thanks. I think the README is a good start, but I think we also need to > improve the comments, which is usually more detailed than the README. > For example, it's not quite acceptable that LogicalLockTransaction and > LogicalUnlockTransaction have about no comments, especially when it's > meant to be public API for decoding plugins.
FWIW, for me that's ground to not accept the feature. Burdening output plugins with this will make their development painful (because they'll have to adapt regularly) and correctness doubful (there's nothing checking for the lock being skipped). Another way needs to be found. - Andres
