On Wed, Dec 01, 2021 at 01:59:05AM -0600, Justin Pryzby wrote:
> On Tue, Nov 30, 2021 at 03:36:45PM +0900, Michael Paquier wrote:
>> - gettext_noop("Waits N seconds on connection startup
>> before authentication."),
>> + gettext_noop("Sets the amount of seconds to wait on
>> connection "
>> + "startup before
>> authentication."),
>
> same
Thanks. This makes things more consistent.
>> {
>> {"checkpoint_warning", PGC_SIGHUP, WAL_CHECKPOINTS,
>> - gettext_noop("Enables warnings if checkpoint segments
>> are filled more "
>> - "frequently than this."),
>> + gettext_noop("Sets the maximum time before warning if
>> checkpoints "
>> + "triggered by WAL volume
>> happen too frequently."),
>> gettext_noop("Write a message to the server log if
>> checkpoints "
>> - "caused by the filling of
>> checkpoint segment files happens more "
>> + "caused by the filling of WAL
>> segment files happens more "
>
> It should say "happen" , since it's referring to "checkpoints".
> That was a pre-existing issue.
Indeed.
>> {"log_parameter_max_length", PGC_SUSET, LOGGING_WHAT,
>> - gettext_noop("When logging statements, limit logged
>> parameter values to first N bytes."),
>> + gettext_noop("Sets the maximum amount of data logged
>> for bind "
>> + "parameter values when logging
>> statements."),
>
> I think this one should actually say "in bytes" or at least say "maximum
> length". It seems unlikely that someone is going to specify this in other
> units, and it's confusing to everyone else to refer to "amount of data"
> instead
> of "length in bytes".
Okay. Do you like the updated version attached?
>> - gettext_noop("Automatic log file rotation will occur
>> after N minutes."),
>> + gettext_noop("Sets the maximum amount of time to wait
>> before "
>> + "forcing log file rotation."),
>
> Should it say "maximum" ? Does that mean anything ?
To be consistent with the rest of your suggestions, we could use here:
"Sets the amount of time to wait before forcing log file rotation"
Thanks,
--
Michael
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 25ac4ca85b..003d649ff5 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -2131,8 +2131,8 @@ static struct config_int ConfigureNamesInt[] =
{
{
{"archive_timeout", PGC_SIGHUP, WAL_ARCHIVING,
- gettext_noop("Forces a switch to the next WAL file if a "
- "new file has not been started within N seconds."),
+ gettext_noop("Sets the amount of time to wait before forcing a "
+ "switch to the next WAL file."),
NULL,
GUC_UNIT_S
},
@@ -2142,7 +2142,8 @@ static struct config_int ConfigureNamesInt[] =
},
{
{"post_auth_delay", PGC_BACKEND, DEVELOPER_OPTIONS,
- gettext_noop("Waits N seconds on connection startup after authentication."),
+ gettext_noop("Sets the amount of time to wait on connection "
+ "startup after authentication."),
gettext_noop("This allows attaching a debugger to the process."),
GUC_NOT_IN_SAMPLE | GUC_UNIT_S
},
@@ -2762,7 +2763,8 @@ static struct config_int ConfigureNamesInt[] =
{
/* Not for general use */
{"pre_auth_delay", PGC_SIGHUP, DEVELOPER_OPTIONS,
- gettext_noop("Waits N seconds on connection startup before authentication."),
+ gettext_noop("Sets the amount of time to wait on connection "
+ "startup before authentication."),
gettext_noop("This allows attaching a debugger to the process."),
GUC_NOT_IN_SAMPLE | GUC_UNIT_S
},
@@ -2819,10 +2821,10 @@ static struct config_int ConfigureNamesInt[] =
{
{"checkpoint_warning", PGC_SIGHUP, WAL_CHECKPOINTS,
- gettext_noop("Enables warnings if checkpoint segments are filled more "
- "frequently than this."),
+ gettext_noop("Sets the maximum time before warning if checkpoints "
+ "triggered by WAL volume happen too frequently."),
gettext_noop("Write a message to the server log if checkpoints "
- "caused by the filling of checkpoint segment files happens more "
+ "caused by the filling of WAL segment files happen more "
"frequently than this number of seconds. Zero turns off the warning."),
GUC_UNIT_S
},
@@ -3006,7 +3008,8 @@ static struct config_int ConfigureNamesInt[] =
{
{"log_parameter_max_length", PGC_SUSET, LOGGING_WHAT,
- gettext_noop("When logging statements, limit logged parameter values to first N bytes."),
+ gettext_noop("Sets the maximum length in bytes of data logged for bind "
+ "parameter values when logging statements."),
gettext_noop("-1 to print values in full."),
GUC_UNIT_BYTE
},
@@ -3017,7 +3020,8 @@ static struct config_int ConfigureNamesInt[] =
{
{"log_parameter_max_length_on_error", PGC_USERSET, LOGGING_WHAT,
- gettext_noop("When reporting an error, limit logged parameter values to first N bytes."),
+ gettext_noop("Sets the maximum length in bytes of data logged for bind "
+ "parameter values when logging statements, on error."),
gettext_noop("-1 to print values in full."),
GUC_UNIT_BYTE
},
@@ -3143,7 +3147,8 @@ static struct config_int ConfigureNamesInt[] =
{
{"log_rotation_age", PGC_SIGHUP, LOGGING_WHERE,
- gettext_noop("Automatic log file rotation will occur after N minutes."),
+ gettext_noop("Sets the amount of time to wait before forcing "
+ "log file rotation."),
NULL,
GUC_UNIT_MIN
},
@@ -3154,7 +3159,8 @@ static struct config_int ConfigureNamesInt[] =
{
{"log_rotation_size", PGC_SIGHUP, LOGGING_WHERE,
- gettext_noop("Automatic log file rotation will occur after N kilobytes."),
+ gettext_noop("Sets the maximum size of log file to reach before "
+ "forcing log file rotation."),
NULL,
GUC_UNIT_KB
},
signature.asc
Description: PGP signature
