On Wed, Dec 1, 2021 at 8:15 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > On Mon, Nov 29, 2021 at 2:21 PM houzj.f...@fujitsu.com > <houzj.f...@fujitsu.com> wrote: > > > > On Thursday, November 11, 2021 2:53 PM houzj.f...@fujitsu.com wrote: > > > Attach the fix patch. > > > 0001 fix data double publish(first issue in this thread) > > > > In another thread[1], Amit L suggested that it'd be nice to add a testcase > > in > > src/test/subscription/. So, attach a new version patch which add a testcase > > in > > t/013_partition.pl. > > > > Thanks, your patch looks good to me. I have slightly changed the > comments and commit message in the attached.
Patch looks good to me too. I confirmed that the newly added subscription test fails with HEAD. > I think we should back-patch this but I am slightly worried that if > someone is dependent on the view pg_publication_tables to return both > parent and child tables for publications that have both of those > tables and published with publish_via_partition_root as true then this > might break his usage. But OTOH, I don't see why someone would do like > that and she might face some problems like what we are trying to solve > here. Yeah, back-patching may not be such a bad idea. Thank you. -- Amit Langote EDB: http://www.enterprisedb.com
