On Wed, Dec 01, 2021 at 04:59:44PM -0500, Melanie Plageman wrote: > Thanks for the review! > > On Wed, Nov 24, 2021 at 8:16 PM Justin Pryzby <pry...@telsasoft.com> wrote: > > You wrote beentry++ at the start of two loops, but I think that's wrong; it > > should be at the end, as in the rest of the file (or as a loop increment). > > BackendStatusArray[0] is actually used (even though its backend has > > backendId==1, not 0). "MyBEEntry = &BackendStatusArray[MyBackendId - 1];" > > I've fixed this in v16 which I will attach to the next email in the thread.
I just noticed that since beentry++ is now at the end of the loop, it's being missed when you "continue": + if (beentry->st_procpid == 0) + continue; Also, I saw that pgindent messed up and added spaces after pointers in function declarations, due to new typedefs not in typedefs.list: -pgstat_send_buffers_reset(PgStat_MsgResetsharedcounter *msg) +pgstat_send_buffers_reset(PgStat_MsgResetsharedcounter * msg) -static inline void pg_atomic_inc_counter(pg_atomic_uint64 *counter) +static inline void +pg_atomic_inc_counter(pg_atomic_uint64 * counter) -- Justin
