Hi,
On 2018-03-30 17:08:26 +0000, Bossart, Nathan wrote:
> +typedef enum RelidOption
> +{
> + RELID_MISSING_OK = 1 << 0, /* don't error if relation doesn't
> exist */
> + RELID_NOWAIT = 1 << 1 /* error if relation cannot be locked */
> +} RelidOption;
I don't like the Relid prefix here. RangeVarGetRelid deals with
*rangevars*, and returns a relation oid. ISTM it'd be more accurate to
call this RV_* or RVID_*. Counterarguments, preferences?
Other than that this looks good, and I plan to push it later today.
Andres
