On Wed, Dec 15, 2021 at 05:50:45PM +0900, Michael Paquier wrote: > Hmm. FWIW, I am working on doing similar for pg_upgrade to switch to > TAP there, and we share a lot in terms of running pg_regress on an > exising cluster. Wouldn't it be better to move this definition to > src/Makefile.global.in rather than src/test/recovery/? > > My pg_regress command is actually very similar to yours, so I am > wondering if this would be better if somehow centralized, perhaps in > Cluster.pm.
By the way, while I was sorting out my things, I have noticed that v4 does not handle EXTRA_REGRESS_OPT. Is that wanted? You could just add that into your patch set and push the extra options to the pg_regress command: my $extra_opts_val = $ENV{EXTRA_REGRESS_OPT} || ""; my @extra_opts = split(/\s+/, $extra_opts_val); -- Michael
signature.asc
Description: PGP signature