On Sun, Dec 19, 2021 at 10:20 PM Amit Langote <amitlangot...@gmail.com>
wrote:

> On Mon, Dec 20, 2021 at 2:00 PM Corey Huinker <corey.huin...@gmail.com>
> wrote:
> > Sorry for the delay. This patch no longer applies, it has some conflict
> with d6f96ed94e73052f99a2e545ed17a8b2fdc1fb8a
>
> Thanks Corey for the heads up.  Rebased with some cosmetic adjustments.
>
> Hi,

+       Assert(partidx < 0 || partidx < partdesc->nparts);
+       partoid = partdesc->oids[partidx];

If partidx < 0, do we still need to fill out partoid and is_leaf ? It seems
we can return early based on (should call table_close(rel) first):

+       /* No partition found. */
+       if (partidx < 0)
+           return NULL;

Cheers

Reply via email to