On Mon, Dec 20, 2021, at 3:45 AM, houzj.f...@fujitsu.com wrote: > Hi, > > When reviewing some replica identity related patches, I found that when adding > primary key using an existing unique index on not null columns, the > target table's relcache won't be invalidated. Good catch.
It seems you can simplify your checking indexForm->indisprimary directly, no? Why did you add new tests for test_decoding? I think the TAP tests alone are fine. BTW, this test is similar to publisher3/subscriber3. Isn't it better to use the same pub/sub to reduce the test execution time? -- Euler Taveira EDB https://www.enterprisedb.com/