On Tue, Dec 21, 2021 at 4:14 AM Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > > On 2021-Dec-20, Peter Eisentraut wrote: > > > I don't see why this is better. It just makes the code longer and adds more > > punctuation and reduces type safety. > > Removing one palloc is I think the most important consequence ... > probably not a big deal though. > > I think we could change the memcpy calls to struct assignment, as that > would look a bit cleaner, and call it a day. >
I think we can all agree that returning PublicationActions as a palloc'd struct is unnecessary. I've attached a patch which addresses that and replaces a couple of memcpy()s with struct assignment, as suggested. Regards, Greg Nancarrow Fujitsu Australia
get_rel_pubactions_improvement.patch
Description: Binary data
