út 21. 12. 2021 v 13:36 odesílatel Justin Pryzby <pry...@telsasoft.com> napsal:
> On Tue, Dec 21, 2021 at 01:29:00PM +0100, Pavel Stehule wrote: > > Hi > > > > út 21. 12. 2021 v 0:09 odesílatel Justin Pryzby <pry...@telsasoft.com> > > napsal: > > > > > I don't understand what 0002 patch does relative to the 0001 patch. > > > Is 0002 to change the error messages from "schema variables" to > "session > > > variables" , in a separate commit to show that the main patch doesn't > > > change > > > regression results ? Could you add commit messages ? > > > > > > I mentioned before that there's a pre-existing use of the phrase > "session > > > variable", which you should change to something else: > > > > > > origin:doc/src/sgml/ref/set_role.sgml: <command>SET ROLE</command> > does > > > not process session variables as specified by > > > origin:doc/src/sgml/ref/set_role.sgml- the role's <link > > > linkend="sql-alterrole"><command>ALTER ROLE</command></link> settings; > > > this only happens during > > > origin:doc/src/sgml/ref/set_role.sgml- login. > > > > > > Maybe "session variable" should be added to the glossary. > > > > > > The new tests crash if debug_discard_caches=on. > > > > > > 2021-12-20 16:15:44.476 CST postmaster[7478] LOG: server process (PID > > > 7657) was terminated by signal 6: Aborted > > > 2021-12-20 16:15:44.476 CST postmaster[7478] DETAIL: Failed process > was > > > running: DISCARD VARIABLES; > > > > How do you inject this parameter to regress tests? > > You can run PGOPTIONS='-c debug_invalidate_caches=1' make check > > I used make installcheck against a running instance where I'd used > ALTER SYSTEM SET debug_discard_caches=on. > > You can also manually run psql against the .sql file itself. > ...which is a good idea since this causes the regression tests take hours. > > Or just add SET debug_discard_caches=on to your .sql file. > ok thank you I'll try it. > -- > Justin >
