On Mon, Dec 27, 2021 at 5:09 PM Pavel Stehule <pavel.steh...@gmail.com> wrote: > > po 27. 12. 2021 v 10:02 odesílatel Peter Eisentraut > <peter.eisentr...@enterprisedb.com> napsal: >> >> This patch adds a new node type Boolean, to go alongside the "value" >> nodes Integer, Float, String, etc. This seems appropriate given that >> Boolean values are a fundamental part of the system and are used a lot. >> >> Before, SQL-level Boolean constants were represented by a string with >> a cast, and internal Boolean values in DDL commands were usually >> represented by Integer nodes. This takes the place of both of these >> uses, making the intent clearer and having some amount of type safety. > > +1
+1 too, looks like a good improvement. The patch looks good to me, although it's missing comment updates for at least nodeTokenType() and nodeRead().
