On Mon, Dec 27, 2021 at 1:40 PM Fujii Masao <masao.fu...@oss.nttdata.com> wrote: > > > > On 2021/12/27 10:40, kuroda.hay...@fujitsu.com wrote: > > Dear Fujii-san, Horiguchi-san, > > > > I confirmed that the feature was committed but reverted the test. > > Now I'm checking buildfarm. > > Attached is the patch that adds the regression test for > postgres_fdw.application_name. Could you review this? > > As Horiguchi-san suggested at [1], I split the test into two, and then > tweaked them as follows. > > 1. Set application_name option of a server option to 'fdw_%d%p' > 2. Set postgres_fdw.application_name to 'fdw_%a%u%%' > > 'fdw_%d%p' and 'fdw_%a%u%%' still may be larger than NAMEDATALEN depending on > the regression test environment. To make the test stable even in that case, > the patch uses substring() is truncate application_name string in the test > query's condition to less than NAMEDATALEN.
Good idea. But the application_name is actually truncated to 63 characters (NAMEDATALEN - 1)? If so, we need to do substring(... for 63) instead. Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/
