On Thu, Nov 25, 2021 at 5:54 PM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > On Thu, Nov 25, 2021 at 3:49 PM Bharath Rupireddy > <bharath.rupireddyforpostg...@gmail.com> wrote: > > > > > > Thanks all. Here's the v1 patch set for the new extension pg_walinspect. > > > Note that I didn't include the documentation part now, I will be doing it > > > a bit later. > > > > > > Please feel free to review and provide your thoughts. > > > > The v1 patch set was failing to compile on Windows. Here's the v2 > > patch set fixing that. > > I forgot to specify this: the v1 patch set was failing to compile on > Windows with errors shown at [1]. Thanks to Julien Rouhaud who > suggested to use PGDLLIMPORT in an off-list discussion. > > [1] (Link target) -> > pg_walinspect.obj : error LNK2001: unresolved external symbol > forkNames [C:\Users\bhara\postgres\pg_walinspect.vcxproj] > pg_walinspect.obj : error LNK2001: unresolved external symbol > pg_comp_crc32c [C:\Users\bhara\postgres\pg_walinspect.vcxproj] > pg_walinspect.obj : error LNK2001: unresolved external symbol > wal_segment_size [C:\Users\bhara\postgres\pg_walinspect.vcxproj] > pg_walinspect.obj : error LNK2001: unresolved external symbol > RmgrTable [C:\Users\bhara\postgres\pg_walinspect.vcxproj] > .\Release\pg_walinspect\pg_walinspect.dll : fatal error LNK1120: 4 > unresolved externals [C:\Users\bhara\postgres\pg_walinspect.vcxproj] > > 5 Error(s)
Here's the v3 patch-set with fixes for the compiler warnings reported in the cf bot at https://cirrus-ci.com/task/4979131497578496?logs=gcc_warning#L506. Please review. Regards, Bharath Rupireddy.
v3-0001-pg_walinspect.patch
Description: Binary data
v3-0001-pg_walinspect-tests.patch
Description: Binary data
