On 2022-Jan-08, Michael Paquier wrote: > The detection regex posted upthread is kind of cool.
Yes, but it's not bulletproof -- it only detects uses of some unqualified object name that is also used with qualification. Here it detected "text" unqualified, but only because we already had pg_catalog.text elsewhere. As an exercise, if you revert this commit and change one of those "text" to "int", it's not detected as a problem. My point is that it's good to have it, but it would be much better to have something bulletproof, which we could use in an automated check somewhere (next to stuff like perlcritic, perhaps). I don't know what, though. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "Cuando no hay humildad las personas se degradan" (A. Christie)
