On 1/12/22, 10:03 PM, "Bharath Rupireddy" <bharath.rupireddyforpostg...@gmail.com> wrote: > On Thu, Jan 13, 2022 at 3:47 AM Bossart, Nathan <bossa...@amazon.com> wrote: >> The only feedback I have for the patch is that I don't think the new >> comments are necessary. > > I borrowed the comments as-is from the CheckPointSnapBuild introduced > by the commit b89e15105. IMO, let the comments be there as they > explain why we are not emitting ERRORs, however I will leave it to the > committer to decide on that.
Huh, somehow I missed that when I looked at it yesterday. I'm going to bump this one to ready-for-committer, then. Nathan
