On Tue, Jan 18, 2022 at 06:46:03AM +0100, Ronan Dunklau wrote: > Hum, there was a missing import in csvlog.c from the fix above. Sorry about > that.
+<!-- Don't forget to also update file_fdw.sgml if you change this table definition --> <programlisting> You are also forgetting that the table listing all the jsonlog fields needs a refresh with this new key called "tags", and that it has a JSON object underneath. If you want to test all the formats supported by logging_destination, wouldn't this stuff be better if tested through TAP with logging_destination set with csvlog, jsonlog and stderr? This is lacking coverage for csvlog.c and jsonlog.c, paths touched by your patch. -- Michael
signature.asc
Description: PGP signature
