On 10/4/21 18:02, Andres Freund wrote: > Hi, > > On 2021-10-04 14:38:16 -0700, Andres Freund wrote: >> 2) For some reason src/tools/install.pl doesn't install plperl[u].control, >> plperl[u]--1.0.sql - But apparently the buildfarm doesn't have that issue, >> because drongo successfully ran the plperl tests? > Oh, figured that one out: Install.pm checks the current directory for > config.pl - but my invocation was from the source tree root (which is > supported for most things). Because of that it skipped installing plperl, as > it though it wasn't installed.
We should fix that, maybe along these lines? iff --git a/src/tools/msvc/Install.pm b/src/tools/msvc/Install.pm index 8de79c618c..75e91f73b3 100644 --- a/src/tools/msvc/Install.pm +++ b/src/tools/msvc/Install.pm @@ -59,6 +59,8 @@ sub Install our $config = shift; unless ($config) { + # we expect config.pl and config_default.pl to be here + chdir 'src/tools/msvc' if -d 'src/tools/msvc'; # suppress warning about harmless redeclaration of $config no warnings 'misc'; cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com