Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)

[Dong Wook Lee]

Hi,

I've applied your patch. I think it's reasonable.
but  IMHO It looks more complicated to read because of many conditions
in if statement.
so what about just moving up if-statement?

Thanks.
Dong Wook Lee

2022년 2월 9일 (수) 오후 7:56, Ranier Vilela <ranier...@gmail.com>님이 작성:
>
> Hi,
>
> I think this change can improve this particular function by avoiding touching 
> value if not needed.
> Test if not isnull is cheaper than test TupleDescAttr is -1.
>
> best regards,
>
> Ranier Vilela

v2_tiny_improvemnt_toast_helper.patch
Description: Binary data