On 2/14/22 16:18, Peter Eisentraut wrote:
Move scanint8() to numutils.c
Move scanint8() to numutils.c and rename to pg_strtoint64(). We
already have a "16" and "32" version of that, and the code inside the
functions was aligned, so this move makes all three versions
consistent. The API is also changed to no longer provide the errorOK
case. Users that need the error checking can use strtoi64().
Reviewed-by: John Naylor <john.nay...@enterprisedb.com>
Discussion:
https://www.postgresql.org/message-id/flat/b239564c-cad0-b23e-c57e-166d883cb...@enterprisedb.com
(moving to hackers)
I guess shame on me for not noticing the thread, but I don't see any
discussion about the potential for breakage to external projects.
scanint8() is exported, and this change breaks at least two extensions I
maintain.
A quick scan (no pun intended ;-)) of github shows other potential
breakage, including at least older (still open source) versions of
pglogical.
Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development
