Hi, On 2022-02-15 09:57:53 -0800, Nathan Bossart wrote: > IIUC you are advocating for something more like the attached patches.
At least for patch 1 yes. Don't have the cycles just now to look at the others. I generally think it'd be a good exercise to go through an use get_dirent_type() in nearly all ReadDir() style loops - it's a nice efficiency win in general, and IIRC a particularly big one on windows. It'd probably be good to add a reference to get_dirent_type() to ReadDir[Extended]()'s docs. Greetings, Andres Freund
