Hi, On February 16, 2022 1:10:35 PM PST, Andrew Dunstan <and...@dunslane.net> wrote: > >On 2/16/22 16:01, Andres Freund wrote: >> Hi, >> >> On 2022-02-16 15:46:28 -0500, Andrew Dunstan wrote: >>> I suggest that we apply this patch: >> +1 >> >>> and if nothing breaks in a few days I will set about a more thorough >>> removal of perl2host() and adjusting everywhere it's called, and we can >>> forget that the whole sorry mess ever happened :-) >> I think we would need an error check against using an msys perl when >> targeting >> native windows, otherwise this'll be too hard to debug. > > >So something like this in Utils.pm: > > >die "Msys targeted perl is unsupported for running TAP tests" if >$Config{osname}eq 'msys';
I don't think we should reject msys general - it's fine as long as the target is msys, no? Msys includes postgres fwiw... >> And we probably should set that environment variable that might fix in-tree >> tests? Or reject in-tree builds? > > >I think that's an orthogonal issue, but yes we should probably set it. >Have you tested to make sure it does what we want? I certainly don't >want to reject in-tree builds. I don't think it's quite orthogonal - msys perl uses sane PATH semantics and thus doesn't have this problem. Andres -- Sent from my Android device with K-9 Mail. Please excuse my brevity.