> On 16 Feb 2022, at 23:36, Andrew Dunstan <and...@dunslane.net> wrote:
> On 2/16/22 17:04, Andrew Dunstan wrote:
>> On 2/16/22 16:36, Daniel Gustafsson wrote:
>>> Seeing msys in TAP tests mentioned in a thread [1] tonight reminded me about
>>> two related (well, one of them) patches I had sitting around, so rather than
>>> forgetting again here are some small cleanups.
>>>
>>> 0001 attempts to streamline how we detect Windows in the TAP tests (after
>>> that
>>> there is a single msys check left that I'm not sure about, but [1] seems to
>>> imply it could go); 0002 removes some unused module includes which either
>>> were
>>> used at some point in the past or likely came from copy/paste.
>>>
>> 0002 looks OK at first glance.
>>
>> 0001 is something we should investigate. It's really going in the wrong
>> direction I suspect. We should be looking to narrow the scope of these
>> platform-specific bits of processing, not expand them.
>
> More specifically, all the tests in question are now passing on jacana
> and fairywren, and their $Config{osname} is NOT 'msys' (it's 'MSWin32').
+1
> So we should simply remove any line that ends "if $Config{osname} eq
> 'msys';" since we don't have any such animals any more.
Since msys is discussed in the other thread let's drop the 0001 from this
thread and just go ahead with 0002.
--
Daniel Gustafsson https://vmware.com/
