I'm not sure about the current status, but found it while playing around with the latest changes a bit, so thought of sharing it here.
+ <varlistentry> + <term><replaceable class="parameter">strategy</replaceable></term> + <listitem> + <para> + This is used for copying the database directory. Currently, we have + two strategies the <literal>WAL_LOG_BLOCK</literal> and the Isn't it wal_log instead of wal_log_block? I think when users input wrong strategy with createdb command, we should provide a hint message showing allowed values for strategy types along with an error message. This will be helpful for the users. On Tue, Feb 15, 2022 at 5:19 PM Dilip Kumar <dilipbal...@gmail.com> wrote: > > On Tue, Feb 15, 2022 at 2:01 AM Maciek Sakrejda <m.sakre...@gmail.com> wrote: > > > Here is the updated version of the patch, the changes are 1) Fixed > review comments given by Robert and one open comment from Ashutosh. > 2) Preserved the old create db method. 3) As agreed upthread for now > we are using the new strategy only for createdb not for movedb so I > have removed the changes in ForgetDatabaseSyncRequests() and > DropDatabaseBuffers(). 3) Provided a database creation strategy > option as of now I have kept it as below. > > CREATE DATABASE ... WITH (STRATEGY = WAL_LOG); -- default if > option is omitted > CREATE DATABASE ... WITH (STRATEGY = FILE_COPY); > > I have updated the document but I was not sure how much internal > information to be exposed to the user so I will work on that based on > feedback from others. > > -- > Regards, > Dilip Kumar > EnterpriseDB: http://www.enterprisedb.com
