Thanks for your comment! Sorry, I did not attach the patch file. This patch focas on master branch.
Best regards, On Thu, 24 Feb 2022 12:15:55 +0900 (JST) Tatsuo Ishii <is...@sraoss.co.jp> wrote: > > Hi, > > > > I found messages inserted a space before the "%" in pgbench. > > I think this is typo because there are no space before the "%" in other > > messages. > > What do you think? > > I think you are right. In English there's should be no space between number > and "%". > AFAIK other parts of PostgreSQL follow the rule. > > > diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c > > index f166a77e3a..4ebe5e6ea4 100644 > > --- a/src/bin/pgbench/pgbench.c > > +++ b/src/bin/pgbench/pgbench.c > > @@ -5598,11 +5598,11 @@ printResults(StatsData *total, > > return; > > > > if (throttle_delay && latency_limit) > > - printf("number of transactions skipped: " INT64_FORMAT " (%.3f > > %%)\n", > > + printf("number of transactions skipped: " INT64_FORMAT " > > (%.3f%%)\n", > > total->skipped, 100.0 * total->skipped / total->cnt); > > > > if (latency_limit) > > - printf("number of transactions above the %.1f ms latency limit: > > " INT64_FORMAT "/" INT64_FORMAT " (%.3f %%)\n", > > + printf("number of transactions above the %.1f ms latency limit: > > " INT64_FORMAT "/" INT64_FORMAT " (%.3f%%)\n", > > latency_limit / 1000.0, latency_late, ntx, > > (ntx > 0) ? 100.0 * latency_late / ntx : 0.0); > > Looks good to me. > > Best reagards, > -- > Tatsuo Ishii > SRA OSS, Inc. Japan > English: http://www.sraoss.co.jp/index_en.php > Japanese:http://www.sraoss.co.jp > > -- KAWAMOTO Masaya <kawam...@sraoss.co.jp> SRA OSS, Inc. Japan
typo_in_pgbench_messages.patch
Description: Binary data