> @@ -1717,8 +1691,8 @@ expand_partitioned_rtentry(PlannerInfo *root, > RangeTblEntry *parentrte, > * parentrte already has the root partrel's updatedCols translated to > match > * the attribute ordering of parentrel. > */ > - if (!*part_cols_updated) > - *part_cols_updated = > + if (!root->partColsUpdated) > + root->partColsUpdated = > has_partition_attrs(parentrel, parentrte->updatedCols, > NULL);
Hmm, surely this should be |= to avoid resetting a value set in a previous call to this function? In the previous coding it wasn't necessary because it was a local variable ... (though, isn't it a bit odd to have this in PlannerInfo? seems like it should be in resultRelInfo, but then you already have it there so I suppose this one does *more*) -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
