On 6 April 2018 at 12:02, David Rowley <david.row...@2ndquadrant.com> wrote: > On 6 April 2018 at 10:35, Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > The only other thing I noted on this pass is that we could get rid of: > > + /* go check the next clause. */ > + if (unsupported_clause) > + break; > > and just "continue" instead of "break" in all cases apart from case > PARTCLAUSE_UNSUPPORTED:
I should have said remove: + if (unsupported_clause) The "break" would still be required. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services