On 2022-02-15 13:02:41 +0900, Michael Paquier wrote: > >> + @regress_command = (@regress_command, @extra_opts); > >> + > >> + $oldnode->command_ok(@regress_command, > >> + 'regression test run on old instance'); > > > > I also think this should take EXTRA_REGRESS_OPTS into account - test.sh did. > > This is already taken into account, as of the @extra_opts bits.
But in a bad way, because EXTRA_REGRESS_OPTS now always wins, even for stuff we want to override. Note how test.sh explicitly specifies port, bindir etc after the pre-existing EXTRA_REGRESS_OPTS.
