On Friday, March 4, 2022 2:23 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > I've attached updated patches. Hi, thank you for updating the patch.
One comment on v4. In v4-0002, we introduce 'commit_lsn' in the ApplyErrorCallbackArg. This member is set for prepare, rollback prepared and stream_abort as well. The new log message format is useful when we have a prepare transaction that keeps failing on the subscriber and want to know the target transaction for the pg_replication_origin_advance(), right ? If this is true, I wasn't sure if the name 'commit_lsn' is the most accurate name for this variable. Should we adjust the name a bit ? Even when we decide to continue to use 'commit_lsn', it might be better to add some comments near the definition, I feel. Best Regards, Takamichi Osumi