On 3/27/18 19:55, Tom Lane wrote:
> Seems reasonable, although I think if you were to delay setting the
> name till the end of that function, you could point to portal->name
> and avoid the extra pstrdup.  Maybe that's useless microoptimization.


>> The term CopySetIdentifier has confused me a bit.  (What's a "set
>> identifier"?)  Maybe use CopyAndSetIdentifier?  (We similarly have
>> MemoryContextResetAndDeleteChildren.)
> No objection, do you want to make the change?

and done

Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Reply via email to