Robert Haas <robertmh...@gmail.com> writes: > On Wed, Feb 2, 2022 at 3:08 AM Amit Langote <amitlangot...@gmail.com> wrote: >> Attached patch removes those.
> Looks right to me. Tom, any comments? I'm pretty sure I left those comments alone on purpose back in 2007, and I don't find simply removing them to be an improvement. In principle, readers might expect that tree walkers/mutators would descend to a SubPlan's query, as they do for a SubLink's query. Calling out the fact that that doesn't happen seems useful to me. If you don't like this particular wording of those comments, we can discuss better wordings ... but I doubt that nothing-at-all is better. regards, tom lane