On Tue, Mar 15, 2022 at 12:30 PM Ashutosh Sharma <ashu.coe...@gmail.com> wrote:
>
> Few comments on the latest patch:
>
> - /* We need to construct the pathname for this database */
> - dbpath = GetDatabasePath(xlrec->dbid, xlrec->tsid);
> + if (xlrec->dbid != InvalidOid)
> + dbpath = GetDatabasePath(xlrec->dbid, xlrec->tsid);
> + else
> + dbpath = pstrdup("global");
>
> Do we really need this change? Is GetDatabasePath() alone not capable
> of handling it?
Well, I mean, that function has a special case for
GLOBALTABLESPACE_OID, but GLOBALTABLESPACE_OID is 1664, and InvalidOid
is 0.
> I think we can shorten these function names to probably
> ScanSourceDBPgClassRel(), ScanSourceDBPgClassTuple() and likewise?
We could, but I don't think it's an improvement.
--
Robert Haas
EDB: http://www.enterprisedb.com
