On Mon, Mar 14, 2022 at 6:28 PM Zhihong Yu <z...@yugabyte.com> wrote: > On Mon, Mar 14, 2022 at 1:33 AM Amit Langote <amitlangot...@gmail.com> wrote: >> On Tue, Jan 18, 2022 at 3:30 PM Amit Langote <amitlangot...@gmail.com> wrote: >> > v13 is attached. >> >> I noticed that the recent 641f3dffcdf's changes to >> get_constraint_index() made it basically unusable for this patch's >> purposes. >> >> Reading in the thread that led to 641f3dffcdf why >> get_constraint_index() was changed the way it was, I invented in the >> attached updated patch a get_fkey_constraint_index() that is local to >> ri_triggers.c for use by the new ri_ReferencedKeyExists(), replacing >> get_constraint_index() that no longer gives it the index it's looking >> for. >> > > Hi, > + partkey_isnull[j] = (key_nulls[k] == 'n' ? true : false); > > The above can be shortened as: > > partkey_isnull[j] = key_nulls[k] == 'n'; > > + * May neeed to cast each of the individual values of the foreign key > > neeed -> need
Both fixed, thanks. -- Amit Langote EDB: http://www.enterprisedb.com
v15-0001-Add-isolation-tests-for-snapshot-behavior-in-ri_.patch
Description: Binary data
v15-0002-Avoid-using-SPI-for-some-RI-checks.patch
Description: Binary data
