On Mon, Mar 21, 2022 at 06:28:28PM -0700, Andres Freund wrote: > Doesn't apply cleanly anymore: http://cfbot.cputube.org/patch_37_2377.log > > Marked as waiting-on-author.
FWIW, per my review the bit of the patch set that I found the most relevant is the addition of a note in the docs of pg_stat_file() about the case where "filename" is a link, because the code internally uses stat(). The function name makes that obvious, but that's not commonly known, I guess. Please see the attached, that I would be fine to apply. -- Michael
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index 8a802fb225..ca111f0745 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -27620,6 +27620,10 @@ SELECT convert_from(pg_read_binary_file('file_in_utf8.txt'), 'UTF8');
platforms only), file creation time stamp (Windows only), and a flag
indicating if it is a directory.
</para>
+ <para>
+ If <parameter>filename</parameter> is a link, this function returns
+ information about the file or directory the link refers to.
+ </para>
<para>
This function is restricted to superusers by default, but other users
can be granted EXECUTE to run the function.
signature.asc
Description: PGP signature
