Hi, On 2022-03-24 16:16:15 +0100, Peter Eisentraut wrote: > On 09.03.22 13:37, Peter Eisentraut wrote: > > v6-0008-meson-prereq-Handle-DLSUFFIX-in-msvc-builds-simil.patch.gz > > > > I think the right way here is actually to go the other way around: > > Move DLSUFFIX into header files for all platforms. Move the DLSUFFIX > > assignment from src/makefiles/ to src/templates/, have configure read > > it, and then substitute it into Makefile.global and pg_config.h. > > > > Then we also don't have to patch the Windows build code a bunch of > > times to add the DLSUFFIX define everywhere. > > This patch should do it.
> From 763943176a1e0a0c954414ba9da07742ad791656 Mon Sep 17 00:00:00 2001 > From: Peter Eisentraut <pe...@eisentraut.org> > Date: Thu, 24 Mar 2022 16:00:54 +0100 > Subject: [PATCH] Refactor DLSUFFIX handling > > Move DLSUFFIX into header files for all platforms. Move the DLSUFFIX > assignment from src/makefiles/ to src/templates/, have configure read > it, and then substitute it into Makefile.global and pg_config.h. This > avoids the need of all users to locally set CPPFLAGS. Reading through it, this looks good to me. Thanks! Greetings, Andres Freund
