As I was tracking down some of these errors in the sql/json patches I noticed that we have a whole lot of them in the code, so working out which one has triggered an error is not as easy as it might be. ISTM we could usefully prefix each such message with the name of the function in which it occurs, along the lines of this fragment for nodeFuncs.c. Thoughts?
cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
diff --git a/src/backend/nodes/nodeFuncs.c b/src/backend/nodes/nodeFuncs.c index 6f6a1f4ffc..675789d104 100644 --- a/src/backend/nodes/nodeFuncs.c +++ b/src/backend/nodes/nodeFuncs.c @@ -270,7 +270,7 @@ exprType(const Node *expr) type = exprType(((const JsonCoercion *) expr)->expr); break; default: - elog(ERROR, "unrecognized node type: %d", (int) nodeTag(expr)); + elog(ERROR, "exprType: unrecognized node type: %d", (int) nodeTag(expr)); type = InvalidOid; /* keep compiler quiet */ break; } @@ -1017,7 +1017,7 @@ exprCollation(const Node *expr) } break; default: - elog(ERROR, "unrecognized node type: %d", (int) nodeTag(expr)); + elog(ERROR, "exprCollation: unrecognized node type: %d", (int) nodeTag(expr)); coll = InvalidOid; /* keep compiler quiet */ break; } @@ -1261,7 +1261,7 @@ exprSetCollation(Node *expr, Oid collation) } break; default: - elog(ERROR, "unrecognized node type: %d", (int) nodeTag(expr)); + elog(ERROR, "exprSetCollation: unrecognized node type: %d", (int) nodeTag(expr)); break; } } @@ -2531,7 +2531,7 @@ expression_tree_walker(Node *node, } break; default: - elog(ERROR, "unrecognized node type: %d", + elog(ERROR, "expression_tree_walker: unrecognized node type: %d", (int) nodeTag(node)); break; } @@ -3588,7 +3588,7 @@ expression_tree_mutator(Node *node, } break; default: - elog(ERROR, "unrecognized node type: %d", + elog(ERROR, "expression_tree_mutator: unrecognized node type: %d", (int) nodeTag(node)); break; } @@ -4448,7 +4448,7 @@ raw_expression_tree_walker(Node *node, } break; default: - elog(ERROR, "unrecognized node type: %d", + elog(ERROR, "raw_expression_tree_walker: unrecognized node type: %d", (int) nodeTag(node)); break; }
