On Thu, Mar 24, 2022 at 2:15 PM Andres Freund <and...@anarazel.de> wrote: > I think we've generally seen the ASLR issue become less prominent on > windows. Whether that's because of the silent retries we added, or because > just about everyone moved to 64bit windows / PG, I don't know. I'd guess both, > with 64bit being the larger influence. > > Wonder if it's worth adding some debug logging to the retry code and stop > disabling ASLR on 64bit windows... It's imo pretty crazy that we loop up to > 100 times in internal_forkexec() around CreateProcess() && > pgwin32_ReserveSharedMemoryRegion() without, as far as I can see, a single > debug message.
Yeah. I think we should commit this patch, but decree that Windows/aarch64 support is experimental only for now. That allows a build farm animal to be set up. Then we add a bit of extra logging and see how it does running our test suite over time and learn more.
