On Sat, Mar 26, 2022 at 1:20 AM Robert Haas <robertmh...@gmail.com> wrote: > > On Sat, Feb 12, 2022 at 6:26 AM Bharath Rupireddy > <bharath.rupireddyforpostg...@gmail.com> wrote: > > FWIW, here's a patch just adding a comment on how the startup process > > can get a free procState array slot even when SInvalShmemSize hasn't > > accounted for it. > > I don't think the positioning of this code comment is very good, > because it's commenting on 0 lines of code. Perhaps that problem could > be fixed by making it the second paragraph of the immediately > preceding comment instead of a separate block, but I think the right > place to comment on this sort of thing is actually in the code that > sizes the data structure - i.e. SInvalShmemSize. If someone looks at > that function and says "hey, this uses GetMaxBackends(), that's off by > one!" they are not ever going to find this comment explaining the > reasoning.
Thanks. It makes sense to put the comment in SInvalShmemSize. Attaching v2 patch. Please review it. Regards, Bharath Rupireddy.
v2-0001-Add-comment-about-startup-process-getting-procSta.patch
Description: Binary data
