On Fri, Mar 25, 2022 at 12:50 PM houzj.f...@fujitsu.com <houzj.f...@fujitsu.com> wrote: > > Attach the new version patch with this change. >
Few comments: ================= 1. I think we can move the keep_alive check after the tracklag record check to keep it consistent with another patch [1]. 2. Add the comment about the new parameter skipped_xact atop WalSndUpdateProgress. 3. I think we need to call pq_flush_if_writable after sending a keepalive message to avoid delaying sync transactions. [1]: https://www.postgresql.org/message-id/OS3PR01MB6275C64F264662E84D2FB7AE9E1D9%40OS3PR01MB6275.jpnprd01.prod.outlook.com -- With Regards, Amit Kapila.
